Repository navigation
feat(keybinds): add word deletion and half-page scrolling - #116
Merged
Merged
Conversation
Owner
|
remove commits not in dev and not part of this pr plz |
Add three configurable keybind actions shared by the app launcher, dmenu, and cclip modes: - delete_word (default Ctrl+W, Ctrl+Backspace, Ctrl+H) removes the last word of the query, or of the tag prompt in cclip mode. Ctrl+H is bound because most terminals send Ctrl+Backspace as ^H. - half_page_up / half_page_down (default Ctrl+U / Ctrl+D) move the selection half a visible page, clamped at the list ends. Grid layouts step by whole rows and rotated layouts flip direction like up/down.
coko7
force-pushed
the
feat/word-erase-half-page
branch
from
October 22, 2026 05:58
5848f6b to
6ccec55
Compare
Contributor
Author
My bad. I should have checked |
Rust 1.99 deprecates AtomicX::fetch_update in favor of try_update, which fails clippy under -D warnings. try_update is only stable since 1.95 and the crate's MSRV is 1.94, so allow the deprecation at both call sites instead of renaming.
coko7
force-pushed
the
feat/word-erase-half-page
branch
from
October 22, 2026 06:41
6ccec55 to
ed1d5a2
Compare
Owner
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add three configurable keybind actions shared by the app launcher,
dmenu, and cclip modes:
word of the query, or of the tag prompt in cclip mode. Ctrl+H is bound
because most terminals send Ctrl+Backspace as ^H.
selection half a visible page, clamped at the list ends. Grid layouts
step by whole rows and rotated layouts flip direction like up/down.
Summary by cubic
Adds three configurable keybind actions shared by the app launcher, dmenu, and cclip modes:
delete_word,half_page_up, andhalf_page_down.delete_word(default Ctrl+W, Ctrl+Backspace, Ctrl+H) removes the last word of the query, or of the tag prompt in cclip mode. Ctrl+H is also bound because most terminals send Ctrl+Backspace as ^H. The previous query is only cloned when debug logging is enabled, and is now a shared helper insrc/ui/editing.rs.half_page_up/half_page_down(default Ctrl+U / Ctrl+D) move the selection half a visible page, clamped at the list ends. Grid layouts step by whole rows, and rotated layouts flip direction like up/down.USAGE.md, the man page, and the exampleconfig.toml/keybinds.tomlto document the new defaults.src/core/state/mod.rstosrc/core/state.rsto satisfy the repository's module layout rule.fetch_updatecalls with#[allow(deprecated)]at both call sites, sincetry_updateneeds Rust 1.95 but MSRV is 1.94.Written for commit ed1d5a2. Summary will update on new commits.
The reported issues violate explicit repository requirements and must be addressed before merging; none establishes a security failure.
Findings
Fix with agent prompt
Summary
Adds configurable word deletion and half-page movement to the launcher, dmenu, and clipboard modes.
These repository requirements must be satisfied before merging.
Reviews (1) · Last reviewed commit: "feat(keybinds): add word deletion and ha..." · Reviewed by Greptile