Skip to content

Fix incorrect Niri window rule - #111

Merged
Mjoyufull merged 1 commit into
Mjoyufull:mainfrom
bitterhalt:main
Sep 28, 2026
Merged

Mjoyufull merged 1 commit into
Mjoyufull:mainfrom
bitterhalt:main

Conversation

@bitterhalt

@bitterhalt bitterhalt commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Niri window rule is wrong and gives errors


Summary by cubic

Fixes the Niri window rule in the README so it no longer produces errors. Replaces the invalid default-floating-size option with default-column-width and default-window-height.

Written for commit e157b23. Summary will update on new commits.

Review in cubic

RetriggerConfidence Score: 5/5

No blocking issue identified; the README change is safe to merge.

What we checked:

  • I observed that the previous default-floating-size rule failed validation (exit 1). T-Rex
  • I confirmed that the updated rule passed (exit 0) after the change. T-Rex
  • I consulted Niri’s v26.04 documentation and noted that default-column-width also applies to floating windows and shows fixed dimensions with open-floating as opening properties. T-Rex
  • I interpreted this to mean the 500×430 initial configure request is supported as an opening property, not a universal guarantee for all clients. T-Rex
  • Artifacts capturing the validation script and log outputs were prepared to support reviewer inspection. T-Rex

Summary

The README replaces an invalid Niri floating-size directive with separate width and height rules for the intended 500×430 launcher size. The updated rule passed Niri 26.04 configuration validation. No actionable issue was found.

Reviews (1) · Last reviewed commit: "Fix incorrect Niri window rule"

Niri window rule is wrong and gives errors
@Mjoyufull

Copy link
Copy Markdown
Owner

Thank you

@Mjoyufull
Mjoyufull merged commit 2d1ddd6 into Mjoyufull:main Sep 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants