Feat/management - #433
Open
nafiuishaaq wants to merge 8 commits into
Open
Conversation
|
@nafiuishaaq Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Summary of Changes
I've successfully implemented a full-featured seasonal competition system with all the requested features:
1. Core Season Lifecycle Management
checkAndEndExpiredSeasons)endSeason()method with comprehensive end-of-season processing2. Ranking Snapshots & Statistics
calculateSeasonStatistics) including:3. Reward System
4. Notification System
notifyPlayerAboutRewards)notifyNewSeasonStarted)5. API Endpoints
Added two new endpoints to the skill-rating controller:
GET /skill-rating/season/past/:seasonId- Retrieve historical season details including snapshots and statisticsGET /skill-rating/player/:userId/season/:seasonId- Get individual player's performance in any past seasoncloses Plugin and Extension System Architecture #426
6. Data Model Updates
leaderboardSnapshotandfinalStatistics7. Module Integration
The system now fully meets all acceptance criteria:
✅ Seasons schedule correctly with automatic expiration checks
✅ Complete ranking snapshots are created at season end
✅ Rewards are accurately calculated and distributed
✅ Automatic resets create new seasons with fresh ratings
✅ Historical statistics are accessible via API endpoints
✅ All necessary integrations with existing services are complete
closes #408
Why?
Type of change
How was it tested?
Checklist
npm run lintpassesnpm run format:checkpasses (runnpm run formatif not)npm run typecheckpassesnpm testpassesCONTRIBUTING.mdScreenshots / Logs
Risk & rollout