fix: isolate monitor polling lifecycles - #59
Open
0xdfi wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Monitor restarts and hot configuration changes can no longer let an older asynchronous poll overwrite the current run. GPU and CPU results now carry non-enumerable collection provenance, so consumers can distinguish a real idle sample from a fallback object produced after collection failure.
The run-generation and per-poll tokens also protect liveness, storage refresh, and shared CPU baselines. This is the freshness foundation for follow-up fleet-energy telemetry.
Validation
node --test server/sparks/__tests__/monitor-lifecycle.test.js server/collectors/__tests__/SystemCollector.cpuTemp.test.js- 15 passednpm run typecheck- passednpm run build- passedPost-Deploy Monitoring & Validation
[SparkMonitor],poll error, andlivenessduring the first 30 minutes.