Repository navigation
Update to 26.3 - #6678
Closed
goncalo3 wants to merge 2 commits into
Closed
Update to 26.3#6678goncalo3 wants to merge 2 commits into
goncalo3 wants to merge 2 commits into
Conversation
26.3 pumps input events during Minecraft's constructor, before Meteor has initialized, so ScreenMixin#onKeyPressed hit a null Modules instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
mc-updatefrom 26.3-pre-1 to the 26.3 release.Changes
Util.getPlatform().openUri(String)was removed in 26.3; its call sites now useBlaze3D.openUri(URI.create(...))ClientLevel#addBreakingBlockEffectwas split intoaddBreakingBlockEffects,addBreakingParticlesandplayBreakingSound. NoRender's block particle hook now targetsaddBreakingParticles, so the breaking sound still playsScreenMixin#onKeyPressedwhen a key is pressed while the game is starting. 26.3 pumps input events from theMinecraftconstructor, before Meteor has initializedTesting
Notes
baritoneis still26.1-SNAPSHOT, since there's no 26.3 build on the Meteor maven yet (see 26.3 baritone#15)URI.createthrows on a malformed URL, where the oldopenUri(String)only logged it. This only matters for URLs that come from addons (the website button in the commits screen)mastermerged intomc-updatewith the conflicts resolved (mostly from the GLFW toInputConstantsmigration), and can open that as a separate PR if it's useful