Repository navigation
fix: reset tun and transparent inbounds when the dial fails - #3406
Open
kasumikira wants to merge 1 commit into
Open
kasumikira wants to merge 1 commit into
kasumikira wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handleTCPConnalways closed the local connection withClose(), so a failed upstream dialreached the TUN application as a FIN and a silent EOF, even though the local handshake had
already been completed and
connect()succeeded.The exit path now applies
SetLinger(0)when the connection never reached the relay, somips, system and mixed send a RST. The abort is limited to
TUN,REDIRandTPROXYinbounds: HTTP CONNECT and SOCKS5 have already written their reply before the tunnel is
called, so an abortive close could discard it. gVisor does not expose
SetLinger, so it isunchanged and needs
endpoint.Abort()inside sing-tun.Refs #2625