Repository navigation
fix: pin node-pty 1.2.0-beta.15 again, and test the pin (#159) - #160
Merged
Merged
Conversation
#130's merge put node-pty ^1.1.0 back, undoing #128, and the owner saw node-pty 1.1.0's 'Assertion failed! remove_pty_baton' dialog again. Re-pin, and a unit test fails on any build without the pin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t
Core's peer was ^1.1.0, which no prerelease matches, so Prism's npm refused the pin (ERESOLVE). Core 0.28.2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t
Prism still asks for 1.1.0 until its own pin lands; an exact peer would make its core bump fail to install. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 10, 2026
* fix: pin node-pty 1.2.0-beta.15 again, and test the pin (#159) #130's merge put node-pty ^1.1.0 back, undoing #128, and the owner saw node-pty 1.1.0's 'Assertion failed! remove_pty_baton' dialog again. Re-pin, and a unit test fails on any build without the pin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t * fix(core): the core asks its hosts for node-pty 1.2.0-beta.15 (#159) Core's peer was ^1.1.0, which no prerelease matches, so Prism's npm refused the pin (ERESOLVE). Core 0.28.2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t * fix(core): the peer allows 1.1.0 or the pinned beta (#159) Prism still asks for 1.1.0 until its own pin lands; an exact peer would make its core bump fail to install. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t * fix: type the pin test's package files, no any (#159) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #159.
The owner's screenshot (2026-10-10) showed node-pty's "Assertion failed! conpty.node ... remove_pty_baton(baton->id)" dialog again, the #127 crash. The cause: #130 (the icon PR, 86ed365) put
package.jsonback tonode-pty ^1.1.0in a merge, undoing #128's pin to1.2.0-beta.15. Stable, the installed PT and Prism have all shipped node-pty 1.1.0 since.package.json/ lockfile:node-pty1.2.0-beta.15 again (and itsallowScriptsentry).src/main/nodePtyPin.test.ts: fails if package.json or the lockfile lose the pin, so a merge cannot drop it silently again (the quit e2e only catches the race sometimes).docs/regression-rules.md: the rule notes the loss and the test.core/package.json: the peer is^1.1.0 || 1.2.0-beta.15(1.1.0 still allowed so Prism's automatic core bump installs before Prism's own pin lands). A^1.1.0peer matches no prerelease, so Prism'snpm cirefused the pin (ERESOLVE). This is a core change, so Prism gets it: once released, Prism takes its own pin in a follow-up PR (prepared on Prismfix/pty-pin). Core 0.28.2, app 0.35.2.Gates: typecheck, lint, unit 1557/0 (the new test failed first). e2e with the beta installed:
quitManyShells4/4 runs pass (12 quits with ten shells); on 1.1.0 it fails about 1 run in 3. Full run: every scenario passes exceptsettingsLook(8 checks), which fails on main too (its "only accent button" check predates #139's accent switches) and is fixed in #161.🤖 Generated with Claude Code
https://claude.ai/code/session_01FHHaWKR4M5QtW7Wecyuk4t