Skip to content

Groups tab tables refactor#8068

Open
danielrafailov1 wants to merge 5 commits into
MarkUsProject:masterfrom
danielrafailov1:groups-tab-tables-refactor
Open

Groups tab tables refactor#8068
danielrafailov1 wants to merge 5 commits into
MarkUsProject:masterfrom
danielrafailov1:groups-tab-tables-refactor

Conversation

@danielrafailov1

@danielrafailov1 danielrafailov1 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes

Refactored the Groups tab students and groups table from react-table v6 to v8.

  • Replaced v6 column APIs (Filter, filterMethod, filterOptions, sortMethod, filtered) with v8 equivalents (meta.filterVariant, filterFn, sortingFn, columnFilters)
  • Converted Assigned / Valid / Extension select filters to I18n label accessors with filterFn: "equals" so they work with the faceted v8 SelectFilter
  • Updated groups_manager tests for the new table UI (extension select filters, _id mocks)
Screenshots of your changes (if applicable) Screenshot 2026-07-19 at 12 17 53 AM

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality) X
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
📖 Documentation update (change that updates documentation)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • [] I have reviewed the test coverage changes reported by Coveralls.
  • [] I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls

coveralls commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 29693102773

Coverage decreased (-0.04%) to 90.37%

Details

  • Coverage decreased (-0.04%) from the base build.
  • Patch coverage: 40 uncovered changes across 1 file (38 of 78 lines covered, 48.72%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
app/javascript/Components/groups_manager.jsx 74 34 45.95%
Total (3 files) 78 38 48.72%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 51266
Covered Lines: 47355
Line Coverage: 92.37%
Relevant Branches: 2484
Covered Branches: 1219
Branch Coverage: 49.07%
Branches in Coverage %: Yes
Coverage Strength: 127.93 hits per line

💛 - Coveralls

@danielrafailov1
danielrafailov1 removed the request for review from david-yz-liu July 19, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants