Merged input yaml records seed used - #130
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #120.
The
merged-input.yamlgenerated in the output directory now records the seed that was used for a simulation even ifForced Seedwas set to false in the original input.Re-running a simulation with
merged-input.yamlnow reproduces (bitwise) the results of the original simulation. It is now an exact reproducibility artefact rather than an exact record of the user inputs (same logic as resolving the relative paths in inputs files to absolute paths before recording them).E.g:
With this in the
input.yamlpassed to APCEMM:The
merged-input.yamlwill be: