Time steps now interpreted appropriately - #122
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now only the transport time step and ice growth time step are used. Other time steps are deprecated - using a new feature, setting these time steps in input.yaml will result in a warning but not throw an error (basically a gentle version of checkRemovedKey, to allow us to transition users more gently and then later turn these into errors). The smallest time step is now respected as the heartbeat time step even when the transport time step is smaller than the growth time step, and the last transport time is actually checked to allow ice growth steps shorter than the transport step. Resolves #107.