Repository navigation
Load the route designer when a plugin has a form field named label - #2912
Merged
mathieuancelin merged 1 commit intoOct 26, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2911
toUpperCaseLabelstreats thelabelkeys it encounters in plugin form schemas as display text. A form field can itself be namedlabel, like thelinksitems of theOtoroshiApiPortalCatalogplugin of otoroshi-api-portal:The value under
labelis then the descriptor of that field, an object, andreplacethrowsa.replace is not a function.loadDataprocesses the schemas of the plugins listed in the designer before clearing its loading state, so such a plugin can block the designer even on routes that do not use it.The helper now applies text formatting only to string values, and processes field descriptors recursively: the nested field keeps its own
Labeland the form renders it as a field. String and empty labels give the same result as before.Checked on
maif/otoroshi:18.0.0-jdk25with a plugin that has this form: with the bundle of the image, the designer never loads; with the bundle built from this branch, it loads and renders the nestedLabelandURLfields.