docs(build): stage translated images atomically to fix a -j race - #4368
Merged
Conversation
.adoc-images-stamp and the per-file TRANSLATED_IMAGE_RULE both stage the same translated images, and under parallel make two cp -f calls on the same destination intermittently fail with "cannot create regular file: File exists". Seen in CI package-indep on PR LinuxCNC#4367 (de/drivers/images/GM_ENDSWpinout.png). Stage via mktemp + mv -f instead: the rename is atomic so concurrent stagers can no longer produce EEXIST, and chmod 644 restores the permissions plain cp used to give the new file (mktemp makes 600).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a rare parallel-build failure seen in CI package-indep (
cp: cannot create regular file '.../de/drivers/images/GM_ENDSWpinout.png': File exists)..adoc-images-stampand the per-fileTRANSLATED_IMAGE_RULEboth stage the same translated images, and under-jtwocp -fcalls on the same destination intermittently fail with EEXIST (reproduced locally with parallel cp loops: 5 failures in 10000 ops). Both recipes now copy to a uniquemktempfile andmv -fatomically, withchmod 644to restore the permissions plain cp produced (mktemp creates 600).Verified with full translated docs builds: all images stage at 644, no leftover temp files.