fix: stop converting timezone on TIMESTAMP (without TZ)#695
Open
adsharma wants to merge 1 commit into
Open
Conversation
…_YEAR for whole years in interval - Timestamp::tryConvertTimestamp no longer applies UTC offset when parsing a string with timezone info. The wall-clock time is preserved as-is, which is the correct semantics for TIMESTAMP (without TZ). - New Timestamp::tryConvertTimestampWithTZ applies the UTC offset, used by TIMESTAMP_TZ (and sub-second variants). - Interval::getMicro uses DAYS_PER_YEAR (365) for whole years instead of DAYS_PER_MONTH * 12 (360), matching the documented constants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #694