Add SigninPage#3041
Open
labkey-alan wants to merge 2 commits into
Open
Conversation
labkey-tchad
approved these changes
Jun 10, 2026
labkey-tchad
left a comment
labkey-tchad
left a comment
Member
There was a problem hiding this comment.
Looks good. Just one nit.
| return new ElementCache(); | ||
| } | ||
|
|
||
| protected class ElementCache extends LabKeyPage<?>.ElementCache |
Member
There was a problem hiding this comment.
These question marks are a relic of a time when I didn't understand generics as well.
Suggested change
| protected class ElementCache extends LabKeyPage<?>.ElementCache | |
| protected class ElementCache extends LabKeyPage<ElementCache>.ElementCache |
(Someday I will do a massive refactor to purge all of the messed up generic types in our test pages/components.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR adds a new page, SignInPage, so we can more easily reauthenticate when submitting and approving Notebooks.
Related Pull Requests
Changes
Tasks 📍