EPMDEDP-17134: fix: remove unused GitLab InsecureSkipVerify#70
Merged
Conversation
Snyk SAST flagged InsecureSkipVerify: true (CWE-295) in the GitLab client. It was an off-by-default, env-gated path that was never used: gitfusion already verifies TLS against Go's default system trust store. Private or self-signed CAs are trusted by mounting the CA into the container trust store (the platform-standard pattern, as the codebase-operator does), so removing the flag keeps certificate verification always on with no functional change. Document the CA-mount approach in the README and chart values, and inline the now-trivial HTTP client helper. Validated end-to-end against a self-signed GitLab: repository, branch, organization and pipeline discovery succeed with the CA mounted and fail closed with an x509 "unknown authority" error without it.
MykolaMarusenko
approved these changes
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snyk SAST flagged InsecureSkipVerify: true (CWE-295) in the GitLab client. It was an off-by-default, env-gated path that was never used: gitfusion already verifies TLS against Go's default system trust store. Private or self-signed CAs are trusted by mounting the CA into the container trust store (the platform-standard pattern, as the codebase-operator does), so removing the flag keeps certificate verification always on with no functional change.
Document the CA-mount approach in the README and chart values, and inline the now-trivial HTTP client helper. Validated end-to-end against a self-signed GitLab: repository, branch, organization and pipeline discovery succeed with the CA mounted and fail closed with an x509 "unknown authority" error without it.