Oob read fixes - #66

Merged

Konstanty merged 99 commits into

Jan 28, 2022

Commits on May 28, 2017

ABC: transpose only needs to look at notes (<26)
Konstanty
committed
f3c1b47
Check memory position isn't over the memory length
Konstanty
committed
d7890bd

Commits on May 31, 2017

Commits on Jun 1, 2017

Commits on Jun 2, 2017

ABC: cleanup tracks correctly.
Konstanty
committed
9f7821a
PSM: make sure reads occur of only valid ins
Konstanty
committed
347eeb8
ABC: 10 digit ints require null termination
Konstanty
committed
1162fd5
FAR: out by one on check
Konstanty
committed
d0adf30
OKT: add one more bound check
Konstanty
committed
5163a38
ABC: terminate early when things don't work in substitute
Konstanty
committed
f82b63a

Commits on Jun 8, 2017

ABC: ensure read pointer is valid before incrementing
Konstanty
committed
cdc0842

Commits on Jun 9, 2017

ABC: prevent possible increment of p past end
Konstanty
committed
4d0bc15
PSM: add missing line to commit
Konstanty
committed
f6dd59a

Commits on Aug 11, 2019

OKT: increase bound check at start to 12.
Konstanty
committed
1db0c41
MED: Ensure that there is room to read one double
Konstanty
committed
083e662
MDL: make sure there is enough space to read the UINT
Konstanty
committed
5523dd6
XM: OOB fixes- don't read items outside 'packsize'
Konstanty
committed
5f4ef8b
MT2: OOB read fixes
Konstanty
committed
1fbf435
MDL: OOB read fixes
Konstanty
committed
57a5cf1

Commits on Aug 12, 2019

ABC: where char is lower case, allow another octave.
Konstanty
committed
2314d9e

Commits on Aug 13, 2019

STM: make sure patterns are not loaded above the maximum size
Konstanty
committed
43f0fc4
ABC: bound divider to not be below 1.
Konstanty
committed
1cde769
MED: fix incorrect logic in previous bound check
Konstanty
committed
187d2da
MID: add bound checking in read functions
Konstanty
committed
f0b1b4e
MT2: check for overflow in comparison
Konstanty
committed
afa4f8e
OKT: follow the convention of subtracting from total length
Konstanty
committed
01f02dc

Commits on Aug 23, 2019

MED: several logic errors when selecting str bounds
Konstanty
committed
1df97f9
MT2: ensure bound checking is done by subtracting from length
Konstanty
committed
8fc8670
MMCMP: add bound check when almost at the end
Konstanty
committed
645d90e

Commits on Aug 24, 2019

Commits on Jun 13, 2021

Commits on Jun 14, 2021

Fix more PSM breakage introduced by #36, 6e384790.
AliceLR
committed
b04985a
Fix crash in PSM loader from invalid sample numbers in pattern data.
AliceLR
committed
401a3f3
Fix crash in MDL loader caused by bad instrument data bounding.
AliceLR
committed
e26e8dd
Fix crash in MDL loader caused by bad track bounding.
AliceLR
committed
e67185d
Fix MT2 loader crashes caused by bad instrument bounding.
AliceLR
committed
d95ee0d
Fix another MDL track bounding bug.
AliceLR
committed
094c3a1
Fix instrument leaks in DBM loader.
AliceLR
committed
2e8cc41
Fix MT2 out-of-bounds nDrumDataLen read.
AliceLR
committed
2af03d9
Fix crash in MT2 loader caused by faulty group bounds check.
AliceLR
committed
9c8cac1
Fix MT2 out-of-bounds reads caused by various faulty/missing checks.
AliceLR
committed
37ca347
Fix STM pattern leaks and pattern size corruption.
AliceLR
committed
3526aa2
Fix MDL crashes due to bad envelope bounding and duplicate envelope chunks.
AliceLR
committed
8253cac
Revise new MDL instrument sample struct bounds check.
AliceLR
committed
8bdf601
Fix out-of-bounds read in XM pattern loader.
AliceLR
committed
14c4506

Commits on Jun 15, 2021

Commits on Jun 16, 2021

Commits on Jun 17, 2021

Fix/cleanup MMCMP bounds checks to reduce slow loads.
AliceLR
committed
772a719

Commits on Jun 18, 2021

Commits on Jun 19, 2021

Fix DMF slow loads caused by missing DMFUnpack EOF check.
AliceLR
committed
f39b8c3
Fix DMF sample leaks caused by duplicate SMPD chunks.
AliceLR
committed
77a1424
Add bounds checks to Extreme's Tracker AMS loader.
AliceLR
committed
1bef4e1
Fix Velvet Studio AMS crash, constify pointers.
AliceLR
committed
11871de
Fix another Extreme's AMS crash.
AliceLR
committed
31910e1
Fix AMS slow loads due to large garbage samples.
AliceLR
committed
ecf8df0
Fix AMS2 instrument bounding checks.
AliceLR
committed
6948105
Add more missing consts in AMS loaders.
AliceLR
committed
4282f68
Add missing AMSUnpack bounds checks.
AliceLR
committed
5e1443f
Fix AMS sample packed length bounding.
AliceLR
committed
2ff82c3
Revise MIDI debug message fix to still use sprintf instead of snprintf.
AliceLR
committed
19a5370
Add missing DMF sample bounds check.
AliceLR
committed
89b591f

Commits on Jun 20, 2021

Commits on Jun 21, 2021

Commits on Jun 22, 2021

Fix off-by-one AMS pattern bounds checks.
AliceLR
committed
70d73b9
Add extra AMS2 pitchenv bounds check in case support is ever added for it.
AliceLR
committed
f768b60
Add missing DMF track bounds check, tweak for consistency.
AliceLR
committed
4317cb7

Commits on Jan 28, 2022