Repository navigation
Bring dev in line with the global theme system branch - #407
Merged
Merged
Conversation
- Every file is now the feature/global-theme-system version at 926753f, byte for byte, so dev becomes identical to that branch - Brings in what that branch has and this one did not, such as the native crash reporting (ExitInfoReader, MemoryContext, TombstoneSummary) and the onboarding carousel - Removes the files that only this branch had, and returns the code the DeepScan cleanup touched to that branch's version
…, Dashboard sync and Seva screen - AudioPlayer and AudioTrackDialog: handleTrackSelect and restoreNotificationCapabilities are declared before the hooks whose dependency lists name them, instead of after - AudioControlBar: sanitizePosition always returns a number, so the two `!= null` checks on its result never failed - useAudioManifest: tracksFromGroups always returns an array, so the `|| []` before the download merge never ran - useTrackPlayer: drop the unused Platform import - ManageDownloads: getDisplayName reads item unguarded on the next line and is never handed null, so the `item &&` guard is dropped - scheduleReminders: every path of updateReminders returns a result, so the fallback object never applied - applyServerActivity takes the server state only; seven test calls still passed a month - buildActivityPayload: getActivityUpdatedSince always resolves to an array, so its `|| []` fallback never ran - SevaScreen takes no props (it reads navigation from useNavigation), so its navigation propTypes described nothing - SevaScreen test: nothing sets the theme to dark, so the switchable theme mode only ever read light
The field draws its placeholder itself and hides that copy from screen readers, since the input already announces it as its hint. Both placeholder tests queried without hidden elements, so one could never find it and the other passed whether or not it was shown.
- .eslintrc.json: restore endOfLine auto, the react-hooks plugin and the __DEV__ global, as dev had them, and drop the two /* global __DEV__ */ comments that now redeclare it - Formatting and import order as ESLint's own fixer writes them - Module-level styles declared before the components that read them, with the circle sizes they use moved above them - Disable comments, with the reason, where the pattern is deliberate; empty catches say why they are empty; ++ written as += 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Every file is set to
feature/global-theme-systemat926753f(manjotkaur27/sundar-gutka-react), so the tree matches that branch exactly: 341 files, 277 modified, 31 added, 33 removed.Added
ExitInfoReader,MemoryContextandTombstoneSummary, withTombstoneSummaryTestOnboardingCarouselwith its slides and images,useOnboardingTrigger, andrevisitTutorialin SettingsActivityCalendar,SlimCalendarStrip,JourneyHeader,LifetimeStats,MostReadSection,MostListenedSection,FeatureTilesRow,KhalisAppsCarouselMyPothisScreen,PothiReaderScreen,PothiShabadRow,useFetchPothidbSeeding.test.js,useOnboardingTrigger.test.js, two images andsrc/calendar.mdRemoved
src/common/sso/session.js,src/services/sync/useAccountSync.js,src/services/sevaRequest.js,src/SevaScreen/useBrowserOnce.js,src/common/settings/appWrite.js,src/common/pothi/itemTitle.js,src/ReaderScreen/components/legacySpeed.js,src/Bookmarks/hooks/useHeader.jsandandroid/app/src/main/res/raw/keep.xmlModified
The remaining 277 files take that branch's version, including the code the DeepScan cleanup in #406 touched.