Repository navigation
Add the new audio player and offline downloads - #403
Closed
manjotkaur27 wants to merge 2 commits into
Closed
manjotkaur27 wants to merge 2 commits into
manjotkaur27 wants to merge 2 commits into
Conversation
Audio - Floating player (full bar, pill and circle) with drag, preview with countdown, track switching and sync-scroll that follows the sung line, including inside merged paragraphs (.pline spans from the database) - Track catalog comes from the backend (users.khalis.net/audios) and is cached for offline use; bundled lyrics and hardcoded track URLs removed - Hardened player setup; the screen stays awake while audio plays; audio pauses when the app loses focus; playback recovery retries until audio resumes and never resumes in the background - Reader from the newer design: themed scrollbar, bars shown on open, nav-bar surface, foldable top layout Downloads - Download button per track, an app-wide download queue, Wi-Fi-only and auto-download settings, and a Manage Downloads screen - Background downloader (@kesha-antonov/react-native-background-downloader) with its patch, notification permission on Android 13+, the iOS background-session hook, and failures reported to Crashlytics - Downloads from the previous version are adopted, never deleted; partial files are downloaded again; cancel, stall, offline and Wi-Fi-only cases stop or restart transfers correctly - Downloaded tracks play from disk with their lyrics after a restart Other - The audio player and Settings audio rows are on the design tokens - Spanish audio strings moved into the Spanish block
- useAudioManifest: track lists and the download registry are always defined, so drop the fallbacks and guards on them - AudioControlBar: sanitizePosition always returns a number, so drop the null checks on the saved position - ManageDownloads: drop the partial null guard on the row item
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audio
Downloads
Other