No longer award prelaunch successful ignition DU if pre-launch ignition failures aren't on

[njits23]

The extra commits in this PR are because the dev branch isn't actually up-to-date.

Make sure you have read and understood the contributing guidelines!

Pull Requests that don't follow the guidelines will be rejected. If you need help or are confused just ask, and we will be glad to help.

• PR being applied to the correct Feature Branch or dev
• PR is not being sent to master

[siimav]

So that means you'll be getting 250 less du on every flight when prelaunch failures are disabled?

[jwvanderbeck]

Yeah I don't really agree with this change. If ignition failures are off that's just a difficulty slider. The ignition du is part of the balanced curve for the engine. You're penalizing someone when they intentionally were trying to set the game easier.

[njits23]

So that means you'll be getting 250 less du on every flight when prelaunch failures are disabled?

I though the per-flight maximum was still 1000 DU, so you'd still get it eventually, right? Unless the cycle DU is now limited to 750.

Is the idea that you want to cache the ignition DU until takeoff has actually happened? I also think that on-pad ignition failures aren't working right now, even when enabled. I couldn't force one to happen during testing, at least.

[siimav]

Per flight max will become 1250 now. And yes, I originally meant awarding the ignition du only after actual liftoff.

[njits23]

Per flight max will become 1250 now.

I'm not sure what you mean here. Because the DU awarding system doesn't allow the total DU gained per flight to exceed the configured maximum, regardless of what the source of that DU was. So if the ignition DU was 999, you'd only be able to gain 1 cycle DU. In the current release version of RO you gain 250DU from ignition, and 750 from cycle, if a full cycle runs.

And yes, I originally meant awarding the ignition du only after actual liftoff.

This PR obviously doesn't implement that, and unfortunately I do not know how to implement a hook in the DU award such that it only fires once the ignited engine has left prelaunch. I suppose I should close the PR?

[siimav]

Check out that RO PR with du changes.

And yes, this would need a coroutine or something to do the delayed awarding.

[siimav]

Try this: #299

[njits23]

#299 seems to work as intended. I tested with multiple engines and in flight, no problems.