Fix device list source to Pixel FI page - #18
Closed
DebugBoard wants to merge 1 commit into
Closed
DebugBoard wants to merge 1 commit into
DebugBoard wants to merge 1 commit into
Conversation
The FI_URL pattern href=".*download.*" also matched download-ota hrefs, and sort -ru ranked the OTA link above the FI link, so both FI_URL and OTA_URL resolved to the same OTA page. That page lists fewer devices than the factory-images page, so newer Pixel models (e.g. Pixel 10 line) published only on factory-images were never picked up.
DebugBoard
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
autopif's device-list scrape was silently stuck on the OTA page instead of the factory-images (FI) page, so any Pixel model published only on FI — currently the entire Pixel 10 line — never appeared in the generated device list.Root cause
FI_URLwas extracted with:That pattern also matches
download-otahrefs, andsort -ruranks.../download-otaabove.../download, sohead -n1returned the OTA page for bothFI_URLandOTA_URL.PIXEL_FI_HTMLandPIXEL_OTA_HTMLended up byte-identical, so theSRC=FI/SRC=OTAlength comparison could never actually pick FI.Fix
Anchor both patterns to the end of the href, in
module/autopif.shand the identical lines in.github/workflows/autopif.yml: