Repository navigation
Conversation
URIs 1.7.2 rejects "http://[::1]evil.com/" when parsing it, so the test's URI(...) call throws URIs.ParseError before HTTP sees the URI. Earlier URIs versions parse it to host "::1" and path "evil.com/", which HTTP rejects with ArgumentError. Accept either. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master CI on bc1b974 (the 2.12.0 bump) fails in every test job at one assertion:
URIs 1.7.2 was registered after #1498's CI ran, and its JuliaWeb/URIs.jl#87 makes
URI("http://[::1]evil.com/")throwParseErrorinstead of returning host"::1"and path"evil.com/". The test builds thatURIbefore HTTP sees it, so the call now fails inside URIs. HTTP's own behavior is unchanged:_parse_http_urlon a string does its own parsing and still throwsArgumentErrorfor these URLs (the loop above this line passes on 1.7.2).The test now accepts either error:
ParseErrorfrom URIs 1.7.2 and later,ArgumentErrorfrom HTTP when an older URIs (compat allows 1.6.1) produces thatURI. Test-only change.Verification: the full suite with URIs 1.7.2 on Julia 1.13.2 locally (see below), and this PR's CI, which now resolves URIs 1.7.2.
🤖 Generated with Claude Code