Skip to content

Stop exporting SMALL_THRESHOLD from Base.Sort#62133

Open
LilithHafner wants to merge 2 commits into
masterfrom
LilithHafner-patch-1
Open

Stop exporting SMALL_THRESHOLD from Base.Sort#62133
LilithHafner wants to merge 2 commits into
masterfrom
LilithHafner-patch-1

Conversation

@LilithHafner

Copy link
Copy Markdown
Member

It shouldn't be public as it's a quintessential implementation detail but this export makes it public via Base.Sort.SMALL_THRESHOLD.

Noticed when attempting to document it in #62026.

It shouldn't be public as it's a quintessential implementation detail but this export makes it public via Base.Sort.SMALL_THRESHOLD.

Noticed when attempting to document it in #62026.
@LilithHafner LilithHafner added minor change Marginal behavior change acceptable for a minor release needs pkgeval Tests for all registered packages should be run with this change labels Jun 16, 2026
@LilithHafner

Copy link
Copy Markdown
Member Author

@nanosoldier runtests()

@nanosoldier

Copy link
Copy Markdown
Collaborator

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

Report summary

❗ Packages that crashed

276 packages crashed on the previous version too.

✖ Packages that failed

8 packages failed only on the current version.

  • Package has test failures: 2 packages
  • Package tests unexpectedly errored: 2 packages
  • Tests became inactive: 1 packages
  • Test duration exceeded the time limit: 3 packages

1364 packages failed on the previous version too.

✔ Packages that passed tests

14 packages passed tests only on the current version.

  • Other: 14 packages

5829 packages passed tests on the previous version too.

~ Packages that at least loaded

3553 packages successfully loaded on the previous version too.

➖ Packages that were skipped altogether

1 packages were skipped only on the current version.

  • Package could not be installed: 1 packages

923 packages were skipped on the previous version too.

LilithHafner added a commit to JuliaCollections/SortingAlgorithms.jl that referenced this pull request Jun 20, 2026
This is the public way to access it. SMALL_ALGORITHM is public in Sort and Sort is public in Base, but SMALL_ALGORITHM is not public in Base.

This also survives JuliaLang/julia#62133.
LilithHafner added a commit to JuliaCollections/SortingAlgorithms.jl that referenced this pull request Jun 20, 2026
Compatibility with JuliaLang/julia#62133, and better use of public API.
@LilithHafner

Copy link
Copy Markdown
Member Author

@nanosoldier runtests(["SortingAlgorithms", "BiBufferedStreams", "Permanents", "BaytesOptim", "SurfaceCoverage", "HypersurfaceRegions", "Trixi", "Test"])

@nanosoldier

Copy link
Copy Markdown
Collaborator

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

Report summary

✖ Packages that failed

1 packages failed only on the current version.

  • Package tests unexpectedly errored: 1 packages

1 packages failed on the previous version too.

✔ Packages that passed tests

6 packages passed tests on the previous version too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor change Marginal behavior change acceptable for a minor release needs pkgeval Tests for all registered packages should be run with this change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants