Stop exporting SMALL_THRESHOLD from Base.Sort#62133
Conversation
It shouldn't be public as it's a quintessential implementation detail but this export makes it public via Base.Sort.SMALL_THRESHOLD. Noticed when attempting to document it in #62026.
|
@nanosoldier |
|
The package evaluation job you requested has completed - possible new issues were detected. Report summary❗ Packages that crashed276 packages crashed on the previous version too. ✖ Packages that failed8 packages failed only on the current version.
1364 packages failed on the previous version too. ✔ Packages that passed tests14 packages passed tests only on the current version.
5829 packages passed tests on the previous version too. ~ Packages that at least loaded3553 packages successfully loaded on the previous version too. ➖ Packages that were skipped altogether1 packages were skipped only on the current version.
923 packages were skipped on the previous version too. |
This is the public way to access it. SMALL_ALGORITHM is public in Sort and Sort is public in Base, but SMALL_ALGORITHM is not public in Base. This also survives JuliaLang/julia#62133.
Compatibility with JuliaLang/julia#62133, and better use of public API.
|
@nanosoldier |
|
The package evaluation job you requested has completed - possible new issues were detected. Report summary✖ Packages that failed1 packages failed only on the current version.
1 packages failed on the previous version too. ✔ Packages that passed tests6 packages passed tests on the previous version too. |
It shouldn't be public as it's a quintessential implementation detail but this export makes it public via
Base.Sort.SMALL_THRESHOLD.Noticed when attempting to document it in #62026.