Skip to content

fix: Base._unsetindex! -> Base.unsetindex! #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nsajko merged 2 commits into from
Oct 3, 2026
+11 −4
Merged

fix: Base._unsetindex! -> Base.unsetindex! #987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f2d12f
fix: `Base._unsetindex!` -> `Base.unsetindex!`
ReubenJ Sep 21, 2026
bbbead4
Apply suggestion from @nsajko
ReubenJ Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/DataStructures.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,13 @@ module DataStructures

import Base.insert!

# public unsetindex! API introduced in 1.14 (julia#58943)
if isdefined(Base, :unsetindex!)
using Base: unsetindex!
else
using Base: _unsetindex! as unsetindex!
end

using OrderedCollections
using OrderedCollections: isordered
export OrderedDict, OrderedSet, LittleDict
Expand Down
4 changes: 2 additions & 2 deletions src/circ_deque.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ end

@inline Base.@propagate_inbounds function Base.pop!(D::CircularDeque)
v = last(D)
Base._unsetindex!(D.buffer, D.last) # see issue/884
unsetindex!(D.buffer, D.last) # see issue/884
D.n -= 1
tmp = D.last - 1
D.last = ifelse(tmp < 1, D.capacity, tmp)
Expand Down Expand Up @@ -92,7 +92,7 @@ Remove the element at the front.
"""
@inline Base.@propagate_inbounds function Base.popfirst!(D::CircularDeque)
v = first(D)
Base._unsetindex!(D.buffer, D.first) # see issue/884
unsetindex!(D.buffer, D.first) # see issue/884
D.n -= 1
tmp = D.first + 1
D.first = ifelse(tmp > D.capacity, 1, tmp)
Expand Down
4 changes: 2 additions & 2 deletions src/deque.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ function Base.pop!(d::Deque{T}) where T
@assert rear.back >= rear.front

@inbounds x = rear.data[rear.back]
Base._unsetindex!(rear.data, rear.back) # see issue/884
unsetindex!(rear.data, rear.back) # see issue/884
rear.back -= 1
if rear.back < rear.front
if d.nblocks > 1
Expand All @@ -323,7 +323,7 @@ function Base.popfirst!(d::Deque{T}) where T
@assert head.back >= head.front

@inbounds x = head.data[head.front]
Base._unsetindex!(head.data, head.front) # see issue/884
unsetindex!(head.data, head.front) # see issue/884
head.front += 1
if head.back < head.front
if d.nblocks > 1
Expand Down
Loading