Repository navigation
Conversation
Owner
Author
|
Superseded by codex/issue-70-windows-codex-exe-final-r2 bound to fresh main ee47c11 with splitPathEnv Windows colon repair. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #70 — resolves native Codex CLI binary discovery on Windows by using the correct platform path delimiter and searching for
codex.exeinstead ofcodex.Root cause
resolveCodexBinary()usedpath.delimiterfrom a POSIX-biased import and searched only forcodex(without.exe), causing complete PATH lookup failure on Windows even when Codex is correctly installed.Changes
src/codex-goal-sessions.ts—resolveCodexBinary():posixandwin32fromnode:pathinstead ofdelimiterwin32.delimiteron Windows,posix.delimiteron POSIXcodex.exeon Windows,codexon POSIXsrc/codex-goal-sessions.test.ts— new test suite:Verification evidence
codex-goal-sessions-ci.test.ts)src/codex-goal-sessions.ts:d79abab34ddc122162a09ab78bccf513f5ebf713src/codex-goal-sessions.test.ts:65f87c6f1b233ad1fa092592b55f7861f0e55a23Candidate
e4bad89e6d525bce8b116d5fc76177fd284323065db22fd8a642016ad8a7a4fdbcd31e56d345a707(current main)src/codex-goal-sessions.ts,src/codex-goal-sessions.test.tsOutstanding
Claim ceiling:
ISSUE_70_SOURCE_CANDIDATE_LOCAL_VERIFIED_PENDING_REMOTE_CI_AND_INDEPENDENT_ACCEPTANCE