Repository navigation
feat(cutover): add carrier-bound finish-bound CLI for drained generations (#462) - #464
Merged
Merged
Conversation
James3014
force-pushed
the
fix/issue-462-cutover-finish-bound
branch
from
October 9, 2026 01:16
a347237 to
3f55df9
Compare
James3014
enabled auto-merge (squash)
October 9, 2026 01:24
…ions (#462) Closes a coordination-bound drained generation whose replacement is already live, using the restart-bound carrier credential pattern, exact live identity check, and the existing exact-pair witness resolver. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
James3014
force-pushed
the
fix/issue-462-cutover-finish-bound
branch
from
October 9, 2026 01:27
3f55df9 to
ca2709c
Compare
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #462 (sidecar-side items remain open) (CLI/closure-path acceptance item).
Problem
When the owner sidecar aborts after activation, a coordination-bound generation stays
drainedeven though the replacement runtime is live.cutover observeis refused as legacy (COORDINATION_REQUIRED), so closure required a hand-written finish-only script.Change
devspace cutover finish-bound --cutover-id --carrier --version --validity-version --credential-file --workspace-id --agent-id --confirm [--json].restart-bound: consumes the rotated owner-private credential intent file (loader factored intoreadCarrierCredentialIntent, behavior unchanged) and binds the carrier vialocalDrainedCutoverContext.performLocalBoundCutoverFinish(incutover-local-restart.ts) requires live/healthzto equalexpectedNewIdentitywith a differentserverInstanceIdthan the old instance, runs the existingresolveDurableReconciliationWitnessFromInventoryexact-pair witness (no duplicated witness logic), then callsDurableOperationManager.finishCutover, which still enforces lease, identity and witness checks.docs/coordination-readers.md.Not in this PR
Sidecar healthz probe fix (
connection: close+ one retry) and resume-from-drained live in the owner sidecar outside this repo; the remaining #462 acceptance items there stay open.Tests
src/carrier-binding.test.ts: finish-bound closes a drained+activated generation (phaseclosed,exact-pairreceipt); refuses old-instance and wrong-build live identity and a wrong credential without state change.src/cli.test.ts: finish-bound usage and flag rejection.npm run test:carrier-binding,npx tsx src/cli.test.ts,npm run typecheck,npm run buildpass.🤖 Generated with Claude Code