Repository navigation
fix: untrack the three agent artifacts #603 re-added - #608
Merged
Merged
Conversation
#606 widened the ignore patterns and merged first, but #603's branch still carried the pre-#606 `.gitignore`. Staging that branch with `git add -A` — which I did while integrating it — re-added the three files the same commit was supposed to strip: .cursor-review-git-dump.py .run-targeted-tests.mjs .test-runner-tmp.sh They match main's patterns now, so untracking is enough; nothing needs to change in `.gitignore`. This is the third time this family has reached main (#598 -> #601/#605, #603 -> here), and each time through a different filename. #607 moves the guard into `isEphemeralWorktreeArtifact`, which the daemon consults when it stages — that one does not depend on the branch's own `.gitignore` being current, which is exactly the gap this commit exists to close. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened
#606 widened the ignore patterns and merged first, but #603's branch still carried the pre-#606
.gitignore. Staging that branch withgit add -A— which I did while integrating it — re-added the three files the same commit was meant to strip:They match main's patterns now (
git check-ignoreconfirms all three), so untracking is enough;.gitignoreneeds no change.Why this keeps happening
Third time this family has reached main — #598 → #601/#605, and now #603 → here — each through a different filename, and this time through a stale copy of the very pattern file meant to stop it.
#607 moves the guard into
isEphemeralWorktreeArtifact, which the daemon consults at staging time. That one does not depend on a branch's own.gitignorebeing current, which is precisely the gap this commit exists to close.🤖 Generated with Claude Code