Skip to content

CI: Punch List #2540 #2541

Description

@xsscx

Post Merge Report

2026-09-12 19:30:16 UTC

After this PR the two front ends disagree about the same document. CIccTagJsonColorantTable::ParseJson() now refuses a 65537-entry colorant table, while CIccTagXmlColorantTable::ParseXml() still accepts it and silently keeps one colorant — and the accepting side is the one that produces wrong data rather than an error. The same holds for CIccTagColorantOrder::Read() on the binary path.I have not resolved that, because refusing a document the library has always accepted is a spec and compatibility call rather than a memory-safety one. The XML helper's last case records the truncation as measured, not endorsed, and its comment says so explicitly and names itself as the case to invert once the divergence is ruled on. Happy to follow up either way.

Originally posted by @xsscx in #2540 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

CopilotCopilot use indicated by MaintainerDocumentationDocumentation-only or documentation-related changeJSONICC JSON parser, config, or round-trip behaviorReview in ProcessIssue is being Reviewed by MaintainersSpecICC specification, tag, color-space, or schema scopeTriagedMaintainer indicates triaged status and ready for developer handoffbugConfirmed or suspected defectciContinuous integration workflow changes

Type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions