Skip to content

CI: Punch List #2310 | Copilot Review Notes #2312

Description

@xsscx

Copilot Review

#2310 (comment)

  1. The end-to-end case constructs a CMYK→Lab CMM, so this profile is an input xform and BPC only executes calcSrcBlackPoint()/pixelXfm(). It never exercises the changed destination path through calcDstBlackPoint() and getBlackXfm() (the BToA/BToD path identified as the defect). Add a Lab/PCS→CMYK destination-xform case and assert that opting out matches the BToA-only reference.

  2. This newly registered standalone suite is missing from the docs/ctest.md “Registered Suites” table. CTest registration changes are required to update that inventory so maintainers can discover and run the focused gate from the canonical CTest documentation.

  3. This new C++ source does not include the required ICC copyright/BSD 3-Clause license header. CONTRIBUTING.md:60-66 requires every new source file to begin with that notice; prepend the repository-standard header before the file description.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

DocumentationDocumentation-only or documentation-related changeQAMaintainer indicates topic of Quality AssuranceTestingCTest, regression, or test coverageciContinuous integration workflow changesneeds-triageMaintainer triage required

Type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions