-
Notifications
You must be signed in to change notification settings - Fork 48
CI: Punch List #2310 | Copilot Review Notes #2312
Copy link
Copy link
Open
Labels
DocumentationDocumentation-only or documentation-related changeDocumentation-only or documentation-related changeQAMaintainer indicates topic of Quality AssuranceMaintainer indicates topic of Quality AssuranceTestingCTest, regression, or test coverageCTest, regression, or test coverageciContinuous integration workflow changesContinuous integration workflow changesneeds-triageMaintainer triage requiredMaintainer triage required
Milestone
Description
Activity
Metadata
Metadata
Assignees
Labels
DocumentationDocumentation-only or documentation-related changeDocumentation-only or documentation-related changeQAMaintainer indicates topic of Quality AssuranceMaintainer indicates topic of Quality AssuranceTestingCTest, regression, or test coverageCTest, regression, or test coverageciContinuous integration workflow changesContinuous integration workflow changesneeds-triageMaintainer triage requiredMaintainer triage required
Copilot Review
#2310 (comment)
The end-to-end case constructs a CMYK→Lab CMM, so this profile is an input xform and BPC only executes
calcSrcBlackPoint()/pixelXfm(). It never exercises the changed destination path throughcalcDstBlackPoint()andgetBlackXfm()(the BToA/BToD path identified as the defect). Add a Lab/PCS→CMYK destination-xform case and assert that opting out matches the BToA-only reference.This newly registered standalone suite is missing from the
docs/ctest.md“Registered Suites” table. CTest registration changes are required to update that inventory so maintainers can discover and run the focused gate from the canonical CTest documentation.This new C++ source does not include the required ICC copyright/BSD 3-Clause license header.
CONTRIBUTING.md:60-66requires every new source file to begin with that notice; prepend the repository-standard header before the file description.