fix(cambricon): prevent duplicate half definitions - #982
Merged
Conversation
baominghelly
marked this pull request as ready for review
September 9, 2026 07:04
voltjia
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inlinelinkage when they are parsed by GNU/Clang host compilers.infiniopslibrary and generated Pythonopsextension, with a regression test covering the CMake configuration.Motivation
Neuware 6.0 leaves the BANG host annotation empty in its FP16/BF16 headers when they are parsed by a host C++ compiler. When generated dispatch or binding sources are split across multiple translation units, each object emits strong definitions for the same
__half/BF16 helpers and the final shared-library link fails withmultiple definitionerrors.This fixes the linkage at the vendor-header boundary without changing dispatch batching or forcing all generated operators into one translation unit.
Type of Change
feat— new feature / new operator / new platformfix— bug fixperf— performance improvement (no behavioral change)refactor— code restructuring without behavior changetest— adding or fixing tests onlydocs— documentation onlybuild/ci— build system or CI configurationchore— tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
The single failure is the existing Cambricon CNNL FP16 GEMM numerical-tolerance case in
tests/test_gemm.py(rtol=0.001,atol=0.001). It is outside the files and linkage path changed by this PR.Test Results on Supported Platforms
Additional validation
Benchmark / Performance Impact
N/A. This changes host-side linkage semantics during compilation and does not change operator kernels or runtime dispatch behavior.
Notes for Reviewers
WITH_CAMBRICON, GNU/Clang, and host C++ compilation. It does not apply to.mludevice compilation or other backends.infiniopsand the generated Pythonopstarget need the compatibility include because each can contain multiple generated dispatch translation units.INFINI_OPS_DISPATCH_BATCH_SIZE.