docs: update changelog for recent changes - #2388
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The only noted issue is a minor changelog-scope nit and no blocking issues remain.
Pull request overview
Updates the unreleased changelog with recent component features, changes, and accessibility fixes.
Changes:
- Documents breadcrumb components and accessibility behavior.
- Records button-group keyboard and ARIA updates.
- Adds recent carousel, date-picker, and dropdown fixes.
File summaries
| File | Summary |
|---|---|
CHANGELOG.md |
Adds release notes for recent features, changes, and fixes. |
Review details
Suppressed comments (1)
CHANGELOG.md:11
- This description is broader than the implementation:
_suppressTabbables()only iterates the default slot, so focusable elements assigned to theprefixorsuffixslots are not removed from the tab sequence when the breadcrumb is disabled. Please narrow this to the default-slot content (or change the component behavior before documenting all slotted content).
- The `igc-breadcrumb` element has the `listitem` role. Put the content of the item, usually an anchor, in the default slot. The `prefix` and `suffix` slots add content before and after that content. The `separator` slot replaces the icon for one item. The `current` attribute sets `aria-current="page"`. The `disabled` attribute sets `aria-disabled` and removes the slotted content from the tab sequence. Assistive technology does not read the separator. The `label` and `separator` CSS parts give access to the two containers. [#1881](https://github.com/IgniteUI/igniteui-webcomponents/pull/1881)
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.