Skip to content

fix(*): removing leftover files, fixing geo-map code snippets - #554

Open
ChronosSF wants to merge 1 commit into
vnextfrom
sstoychev/nugetfeed-geo-map-fixes
Open

ChronosSF wants to merge 1 commit into
vnextfrom
sstoychev/nugetfeed-geo-map-fixes

Conversation

@ChronosSF

Copy link
Copy Markdown
Member

Closes #553

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The Angular snippets in the updated GeoMap topics have inconsistent imports/casts (component vs non-component types), making the snippets incorrect as written.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR addresses Issue #553 by ensuring the Angular documentation build no longer renders non-Angular code/content: it scopes GeoMap “binding multiple shapes” snippets per platform and removes the Blazor-focused NuGet feed topics from the Angular doc set.

Changes:

  • Split combined GeoMap code snippet sections into per-platform <PlatformBlock> blocks (React / Angular / WebComponents) so Angular pages render Angular-only snippets.
  • Remove nuget-feed.mdx topics from the Angular docs (EN/JP) to prevent generating the /nuget-feed route and including it in the Angular sitemap.
File summaries
File Description
docs/xplat/src/content/jp/components/geo-map-binding-multiple-shapes.mdx Adds per-platform PlatformBlock wrappers around snippet sections to avoid cross-platform snippet leakage.
docs/xplat/src/content/en/components/geo-map-binding-multiple-shapes.mdx Same platform scoping changes for the EN topic.
docs/angular/src/content/jp/components/nuget-feed.mdx Removed from Angular docs to prevent non-Angular content from being generated in the Angular site.
docs/angular/src/content/en/components/nuget-feed.mdx Removed from Angular docs to prevent non-Angular content from being generated in the Angular site.
Review details

Suppressed comments (6)

docs/xplat/src/content/en/components/geo-map-binding-multiple-shapes.mdx:403

  • This cast uses IgxGeographicShapeSeries, but the Angular snippets in this topic use the *Component types (and after fixing the import above, IgxGeographicShapeSeriesComponent will be in scope). Update the cast so the snippet is self-consistent and compiles as shown.
</PlatformBlock>

docs/xplat/src/content/en/components/geo-map-binding-multiple-shapes.mdx:498

  • The Angular polyline snippet imports IgxGeographicPolylineSeriesComponent but casts to IgxGeographicPolylineSeries (not imported). Cast to the component type to keep the snippet self-contained.
</PlatformBlock>

docs/xplat/src/content/en/components/geo-map-binding-multiple-shapes.mdx:599

  • The Angular points snippet imports IgxGeographicSymbolSeriesComponent but casts to IgxGeographicSymbolSeries (not imported). Cast to the component type so the snippet compiles as written.
<PlatformBlock for="WebComponents">

docs/xplat/src/content/jp/components/geo-map-binding-multiple-shapes.mdx:405

  • ここで IgxGeographicShapeSeries へキャストしていますが、このトピック内の Angular スニペットは *Component 型で統一されています(上の import 修正後は IgxGeographicShapeSeriesComponent が利用可能になります)。キャストも IgxGeographicShapeSeriesComponent に更新してください。
</PlatformBlock>

docs/xplat/src/content/jp/components/geo-map-binding-multiple-shapes.mdx:500

  • IgxGeographicPolylineSeriesComponent を import しているのに、キャスト先が IgxGeographicPolylineSeries(未 import)になっています。スニペットを自己完結させるため IgxGeographicPolylineSeriesComponent にキャストしてください。
</PlatformBlock>

docs/xplat/src/content/jp/components/geo-map-binding-multiple-shapes.mdx:601

  • IgxGeographicSymbolSeriesComponent を import しているのに、キャスト先が IgxGeographicSymbolSeries(未 import)になっています。スニペットがコンパイルできるよう IgxGeographicSymbolSeriesComponent にキャストしてください。
<PlatformBlock for="WebComponents">
  • Files reviewed: 4/8 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

<PlatformBlock for="Angular">

```ts
import { IgxGeographicPolylineSeriesComponent } from 'igniteui-angular-maps';
<PlatformBlock for="Angular">

```ts
import { IgxGeographicPolylineSeriesComponent } from 'igniteui-angular-maps';
@viktorkombov viktorkombov added the 💥 status: in-test PRs currently being tested label Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💥 status: in-test PRs currently being tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix non-Angular content generated in Angular documentation

3 participants