Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Missing-value filters can return all data, and transition timestamps are incorrectly included.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds string sample-log filtering, validation, and corrected filter handling in histogram/output generation.
Changes:
- Supports case-insensitive string predicates and HDF5 string logs.
- Sorts and applies include/exclude ranges correctly.
- Adds tests, plotting support, and documentation.
File summaries
| File | Description |
|---|---|
src/test_utils.rs |
Adds mock sample-log creation. |
src/stats.rs |
Propagates log-filter errors. |
src/interface.rs |
Exposes string filtering. |
src/filters/mod.rs |
Exports predicates. |
src/filters/api.rs |
Adds string predicates and errors. |
src/data/save/sample_logs.rs |
Saves and filters string logs. |
src/data/sample_logs.rs |
Loads, filters, and sorts log ranges. |
src/data/nexus_data.rs |
Returns string logs to Python. |
src/batch_interface.rs |
Validates and applies string filters. |
MNeuEventLib/plotting.py |
Plots categorical logs. |
docs/source/how-to/filtering.ipynb |
Documents text filtering. |
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to filter sample logs which are strings. Fixes #70.
Also fixes a bug where sample log filters are filtered wrong in output files as
apply_filtersignores whether the time filters are include or exclude, and adds some validation for sample logs when the filter is created rather than when it is calculated.also now sorts sample log times. fixes #100