Fix notebook 1.3 solve against current openTEPES master - #18
Merged
Conversation
Notebook 1.3 replicates the openTEPES_run pipeline call by call. Current openTEPES master sets pIndCompleteProblem, pIndSequentialSolving and pBdTol on the model before the solve, and StageIterativeSolving now reads pIndCompleteProblem. The notebook never set them, so the scheduled submodule bump failed with 'ConcreteModel object has no attribute pIndCompleteProblem'. Set the three flags next to the existing pIndSectorDecomposition flag. Verified by running the notebook against openTEPES master tip 4ec96bd4 on Python 3.12: it solves to optimal, 159.211 MEUR, matching the committed output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notebook 1.3 replicates the
openTEPES_runpipeline call by call. Current openTEPES master setspIndCompleteProblem,pIndSequentialSolvingandpBdTolon the model before the solve, andStageIterativeSolvingreadspIndCompleteProblem. The notebook did not set them, so the scheduled submodule-bump job failed withAttributeError: 'ConcreteModel' object has no attribute 'pIndCompleteProblem'.This sets the three flags next to the existing
pIndSectorDecompositionflag.Verified against openTEPES master tip
4ec96bd4on Python 3.12: the notebook solves to optimal, 159.211 MEUR, matching the committed output.