Support conda FFTW in make and python bindings#5
Open
samwaseda wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the build system to better support environments where packages are installed via Conda, particularly for FFTW and Python bindings. The main changes add automatic detection and usage of Conda-provided include and library paths in both Makefile and CMake builds, and refactor the Python bindings Makefile for consistency and maintainability.
Conda environment integration:
Makefile.defsnow detects if FFTW is installed in a Conda environment by checking forfftw3.hand relevant libraries in$CONDA_PREFIX, updatingINCLUDES,STDLIBS, and runtime paths accordingly.Findfftw.cmakenow checks for Conda-specific include and library directories, using$CONDA_PREFIXas a search hint for FFTW headers and libraries.Python bindings build improvements:
pythonbindings/Makefileis refactored to include common build settings fromMakefile.defs, use variables for Python configuration, and set up Conda-specific runtime paths for shared library loading.