Keep fetch source time out of git checkouts - #24091
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
馃煛 Changes recommended
Address the critical symlink-safety issue before approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates resource staging to keep .source_modified_time out of Git checkout status.
Changes:
- Adds the timestamp file to Git鈥檚 local exclude rules.
- Adds regression coverage for the exclusion behavior.
| File | Summary |
|---|---|
Library/鈥婬omebrew/鈥媟esource.rb |
Adds Git exclusion handling; a critical symlink-safety issue remains. |
Library/鈥婬omebrew/鈥媡est/鈥媟esource_spec.rb |
Tests exclusion registration; coverage should verify Git recognizes the rule. |
馃挕 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
daeho-ro
force-pushed
the
fetch-staging-clean-git-tree
branch
from
September 25, 2026 15:26
7568945 to
0b3542e
Compare
MikeMcQuaid
approved these changes
Sep 25, 2026
MikeMcQuaid
left a comment
MikeMcQuaid
left a comment
Member
There was a problem hiding this comment.
Makes sense, thanks! Looks good when 馃煝 (style looks off just now)
MikeMcQuaid
force-pushed
the
fetch-staging-clean-git-tree
branch
from
September 26, 2026 00:29
0b3542e to
441eeda
Compare
MikeMcQuaid
enabled auto-merge
September 26, 2026 00:31
daeho-ro
force-pushed
the
fetch-staging-clean-git-tree
branch
from
September 26, 2026 15:18
441eeda to
02c7cc7
Compare
- `def fetch` makes `Resource#unpack` write `.source_modified_time` into the shared staging directory, which is the formula's `buildpath`. - For git checkouts this shows up as an untracked file, so builds that embed the working tree state report a dirty tree: Go stamps `vcs.modified=true` and `circleci version` prints `(modified)`. - Add it to `.git/info/exclude`, as `.brew_home` gets a `.gitignore`.
daeho-ro
force-pushed
the
fetch-staging-clean-git-tree
branch
from
September 26, 2026 15:33
02c7cc7 to
cbbe73b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?.source_modified_timemay break source completness, likeand so exclude it by using git exclude.