Skip to content

Avoid sudo for user-local cask app groups - #24011

Merged
MikeMcQuaid merged 1 commit into
mainfrom
cask-user-appdir-permissions
Sep 17, 2026
Merged

Avoid sudo for user-local cask app groups#24011
MikeMcQuaid merged 1 commit into
mainfrom
cask-user-appdir-permissions

Conversation

@MikeMcQuaid

@MikeMcQuaid MikeMcQuaid commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • Preserve existing groups outside system directories so personal app installs and upgrades do not need sudo to change groups.
  • Keep removing group and other write permissions for all apps and normalising group ownership for system installations.

Fixes #24003 (comment)

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?
  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Codex with GPT 6 Astra at xhigh effort, with local review and testing.

Copilot AI lite review requested due to automatic review settings September 17, 2026 07:36
@MikeMcQuaid MikeMcQuaid mentioned this pull request Sep 17, 2026
Merged
8 tasks
Copilot AI reviewed Sep 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@MikeMcQuaid
Avoid sudo for user-local cask app groups
e95efa6 
- Try changing app groups without sudo everywhere, allowing failure
  outside system directories so personal upgrades do not prompt.
- Keep removing group and other write permissions for all apps and
  requiring the expected group for system installations.

Fixes #24002
@MikeMcQuaid
MikeMcQuaid force-pushed the cask-user-appdir-permissions branch from 51c7a3c to e95efa6 Compare September 17, 2026 08:34
@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Sep 17, 2026
Merged via the queue into main with commit f8ad208 Sep 17, 2026
51 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the cask-user-appdir-permissions branch September 17, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@bevanjkay bevanjkay bevanjkay approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MikeMcQuaid @bevanjkay