Conversation
added 2 commits
September 24, 2026 20:42
Add virtSwitchName, dns1-3, searchDomain, ntp1, ntp2, proxy and noProxy to the HVM cluster server create config, add a matching HVM read variant so these fields round-trip on cluster read.
Drop the typed HVM read variant; the HVM 2.0 fields round-trip through the generic echoed config, consistent with how the existing HVM config fields are read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
Adds the HVM Cluster 2.0 network configuration fields to
clusterServerCreateConfigHVM(the HVM variant of the cluster server createconfig):virtSwitchNamedns1,dns2,dns3searchDomainntp1,ntp2proxy,noProxyAll are optional strings. On the Morpheus API these are written into the
cluster server config when the selected cluster layout supports cluster
version 2.0 or greater.
Read side
The cluster read
configis intentionally left as a generic object: clusterconfigis polymorphic across provision types and the API echoes back moreproperties than were set, so consumers read the values they set back out of
the generic map. These fields round-trip that way, consistent with the other
HVM config fields.