Network create/update: add the network-context fields the API accepts - #371
Merged
Merged
Conversation
- Create: networkServer, scopeId, vxlanId, parentNetwork, availabilityZone - Update: name, the IPv6 fields (cidrIPv6, gatewayIPv6, netmaskIPv6, dnsPrimaryIPv6, dnsSecondaryIPv6, dhcpServerIPv6, poolIPv6), ipv4Enabled/ipv6Enabled, networkServer, parentNetwork - Note on the core fields which network-type flag governs whether an update applies them; the fields the API never returns are marked Terraform provider 2.2 (MORPH-17744).
eoghanino
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The network create and update request schemas were missing fields the API accepts, so a generated client could not send them without falling back to untyped extras. This adds them, with descriptions that say which are never returned in responses and which network-type flag governs whether an update applies the core fields.
Changes
networkCreate.yaml:networkServer({id}) — the network server (integration) a plugin-managed network type requires; Morpheus 9.1 requires it on create for such types (for example the HVM port group types). Not returned by the API.scopeId— NSX-T transport zone for a segment on NSX-T 2.x. Not editable after create; not returned.vxlanId— VXLAN ID of an OVS overlay network. Not editable after create; not returned.parentNetwork({id}) — parent of a custom child network. Not returned.availabilityZone— availability zone of an Amazon subnet. Set on create only; returned.networkUpdate.yaml:name,ipv4Enabled,ipv6Enabled,cidrIPv6,gatewayIPv6,netmaskIPv6,dnsPrimaryIPv6,dnsSecondaryIPv6,dhcpServerIPv6,poolIPv6,networkServer,parentNetwork— all accepted by the update endpoint but absent from the schema.name,cidr,gateway,vlanId,dhcpServer,dnsPrimary,dnsSecondary) note which network-type flag (nameEditable,cidrEditable,gatewayEditable,vlanIdEditable,dhcpServerEditable,dnsEditable) decides whether the update applies them; a change to a field whose flag is off is accepted and ignored.scopeIdandvxlanIdare deliberately not added to the update schema: no network type edits them after create.No change to the response schema: it already carries everything the API returns for a network.
Validation
redocly lint openapi.yamlpasses. The Spectral step in CI could not be reproduced locally: the current@stoplight/spectral-clifails on the unchangedtf-devbundle as well (Cannot read properties of null (reading 'enum')), so that is a tooling mismatch rather than something this change introduces.Context
Needed by Terraform provider 2.2 (MORPH-17744), whose network resource now sends these as typed fields. The provider vendors the SDK generated from this spec, so the provider change is self-contained; this PR should merge after it.