Skip to content

Fix tools recompilation on older haxe versions #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aidan63 merged 2 commits into from
Sep 3, 2026
Merged

Fix tools recompilation on older haxe versions #1381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e35d6b
Fix tools recompilation on older haxe versions
tobil4sk Sep 1, 2026
3af88af
Fix run.n recompilation as well
tobil4sk Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tools/hxcpp/Compiler.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,8 +694,7 @@ class Compiler
{
mPCH = inPCH;
createCompilerVersion();
final regex = ~/clang/i;
if (inPCH != null && regex.match(mCompilerVersionString)) {
if (inPCH != null && ~/clang/i.match(mCompilerVersionString)) {
mPCH = "clang";
}
switch (mPCH) {
Expand Down
4 changes: 2 additions & 2 deletions tools/hxcpp/Setup.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ class Setup
try
{
var lines = ProcessManager.readStdout(wasmOptExe, ["--version"]);
if (lines?.length>0)
if (lines.length>0)
{
Log.v('Found $wasmOptExe in PATH ${lines[0]}');
ioDefines.set("HXCPP_WASM_OPT", wasmOptExe);
Expand Down Expand Up @@ -623,7 +623,7 @@ class Setup

var minPlatform:Null<Int> = try {
haxe.Json.parse(sys.io.File.getContent(platformsJson)).min;
} catch (e) {
} catch (e:Dynamic) {
Log.warn("Unable to determine minimum supported Android platform: " + e.toString());
null;
};
Expand Down
7 changes: 6 additions & 1 deletion tools/run/RunMain.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
import sys.FileSystem;
#if haxe4
import sys.thread.Thread;
#elseif neko
import neko.vm.Thread;
#end

class RunMain
{
Expand Down Expand Up @@ -26,7 +31,7 @@ class RunMain
log(" haxe compile.hxml");

var gotUserResponse = false;
sys.thread.Thread.create(function() {
Thread.create(function() {
Sys.sleep(30);
if (!gotUserResponse)
{
Expand Down
Loading