Repository navigation
fix(cache): reparse documents when cached media files are missing - #472
Merged
LarFii merged 1 commit intoNov 12, 2026
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Parsing an unchanged source can return cached blocks containing dead local paths after parser output files are deleted. Reject that cache entry and run the parser again so the media can be regenerated.
Related Issues
#431 fixes BatchParser manifest reuse when an entire output directory is missing. This fixes the separate parse-cache hit in
parse_document, including a missing media file within an existing output directory.Changes Made
Validation
On Python 3.12:
tests/suite: 1134 passed, 2 skipped, 1 xfailed. The two skipped modules require the optional WeasyPrint dependency, which is not installed in this environment.git diff --check HEAD^ HEAD: passed.Checklist
Additional Notes
AI assistance was used for investigation, implementation, testing and independent review. No independent human review is claimed. Native MinerU/model inference and additional platforms were not exercised.