Repository navigation
fix(resilience): avoid exponent overflow in capped retries - #465
Open
jackiectl2 wants to merge 2 commits into
Open
jackiectl2 wants to merge 2 commits into
jackiectl2 wants to merge 2 commits into
Conversation
Signed-off-by: Tianlang (Jackie) Chen <305351710+jackiectl2@users.noreply.github.com>
Signed-off-by: Tianlang (Jackie) Chen <305351710+jackiectl2@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Advance the raw exponential delay by multiplication instead of recomputing a potentially overflowing power. Capped long retry sequences can reach a later successful attempt without raising OverflowError in the backoff calculation.
Changes Made
Maintain the raw exponential delay between attempts in both retry decorators, while preserving the delay cap. Add long synchronous and asynchronous retry regressions.
Checklist
Validation
31 resilience tests passed, including synchronous and asynchronous regressions that fail without the fix. All repository pre-commit hooks, including the pinned Ruff checks, passed.
Full ingestion/model suite not run.