fix[next]: Detect ROCm device architecture instead of hard-coding gfx942 - #2796
Open
tehrengruber wants to merge 1 commit into
Open
fix[next]: Detect ROCm device architecture instead of hard-coding gfx942#2796tehrengruber wants to merge 1 commit into
tehrengruber wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_query_device_arch()inotf/compilation/common.pyreturns a hard-coded"gfx942"(MI300A) for ROCm devices — an old TODO. Every GPU binary is therefore compiled for gfx942 only (get_device_arch()feeds both the DaCe and the gtfn/CMake build); on any other AMD GPU the fat binary contains no matching code object and the first kernel launch segfaults insidelibamdhip64(the stub-basedhipLaunchKerneldoes not return a clean error for this case). Observed on a gfx1103 APU; settingHIPARCHSexplicitly works around it.Fix
Query the architecture from the device via
cupy.cuda.runtime.getDeviceProperties(0)["gcnArchName"], stripping the target-feature suffix (e.g.gfx90a:sramecc+:xnack-→gfx90a), with the same error handling as the CUDA branch. TheCUDAARCHS/HIPARCHSenvironment override precedence is unchanged. Verified on a gfx1103 APU (ROCm 7.2): detection returnsgfx1103.AI disclaimer: Description and code were developed with the help of LLMs. Code was reviewed in detail, description briefly read, too verbose, but doesn't matter.