fix[next]: more dace transformation determinism - #2778
Merged
Conversation
edopao
reviewed
Aug 11, 2026
|
|
||
| # This is the dataflow that can not be relocated. | ||
| non_relocatable_connectors: set[str] = set() | ||
| non_relocatable_connectors: OrderedSet[str] = OrderedSet() |
Contributor
There was a problem hiding this comment.
The function is returning a list. I was thinking whether we could keep non_relocatable_connectors a regular set, but in the return statement sort the connectors alphabetically: sorted(list(non_relocatable_connectors))
Contributor
Author
There was a problem hiding this comment.
I would propose the exact opposite: remove the sorting and return an ordered set:
- Sorting statements usually hinder readability and they amplify performance indeterminism from unstable symbols, whereas relying on insertion order makes unstable symbols mostly harmless as they only matter for comparability.
- The sorting approach only works for sortable entities, whereas insertion order always works so just relying on insertion order gives a simple recipe.
Contributor
There was a problem hiding this comment.
You are right, I like in particular the argument "Sorting statements amplify performance indeterminism from unstable symbols".
OK, agreed. Let's return an OrderetSet instead of a list.
Contributor
Author
|
cscs-ci run dace-determinism |
Contributor
Author
|
cscs-ci run dace-determinism |
edopao
approved these changes
Aug 13, 2026
tehrengruber
changed the title
tehrengruber
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remaining changes from #2568 not in #2635.