Sc 115 add pagination to all tables that do not have it by nbeatty-gpa · Pull Request #873 · GridProtectionAlliance/SystemCenter

nbeatty-gpa · 2026-06-10T16:01:29Z

Adds pagination to tables, especially in "info" tabs

Jira Work Item(s)

SC-115

Copilot

Pull request overview

This PR adds pagination support across multiple SystemCenter UI tables (especially “info”/detail tabs) by wiring table views to paged search endpoints and introducing/using paged APIs on the backend where needed.

Changes:

Add <Paging /> controls to many TSX table views and update sorting/page state handling.
Introduce/extend paged API endpoints for several resources (e.g., security group users, asset group members, asset connections/channels, location images).
Extend Redux/EventChannel slice state to support paged results and update store typing setup.

Reviewed changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/ValueListGroup/ValueListGroupItem.tsx	Adds paging and server-side sort/page flow for value list items.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/User/UserGroup/GroupUsers.tsx	Switches group user listing to a paged backend endpoint and adds paging UI.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/User/UserGroup/ByUserGroup.tsx	Refactors to `GenericController` paged search and adds paging UI.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/User/User/ByUser.tsx	Refactors to `GenericController` paged search and adds paging UI.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Store/Store.ts	Updates store typing and reducer composition structure.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Store/EventChannelSlice.ts	Adds paged-search thunk/state/selectors for event channels.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/RemoteXDA/RemoteMeterTab.tsx	Adds paging support to remote meter table search results.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/RemoteXDA/RemoteAssetTab.tsx	Adds paging support to remote asset table search results.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Meter/MeterTrendChannel.tsx	Adds paging to trend channel table.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Meter/MeterEventChannel.tsx	Adds paging to event channel table using new paged slice data.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Meter/ChannelScaling/ChannelScalingForm.tsx	Adds client-side paging for scaling wrappers table.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Location/LocationImages.tsx	Adds paging UI for location image lists and updates API call shape.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/ExternalDB/ExternalDBTables.tsx	Adds paging UI and paged search for external DB tables listing.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/ExternalDB/ExternalDBTableFields.tsx	Moves additional-field table to paged backend query and adds paging UI.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Customer/CustomerMeter.tsx	Switches customer meter listing to paged search and adds paging UI.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Customer/CustomerAsset.tsx	Switches customer asset listing to paged search and adds paging UI.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/CommonComponents/ExternalDBUpdate.tsx	Updates UI message strings during external DB updates.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/ChannelGroup/ChannelGroupItem.tsx	Adds paging and server-side sort/page flow for channel group details.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/AssetGroups/MeterAssetGroup.tsx	Adds paging UI and paged backend calls for meters in an asset group.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/AssetGroups/ByAssetGroup.tsx	Adds paging UI and paged searching for asset group listing.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/AssetGroups/AssetGroupAssetGroup.tsx	Adds paging UI and paged backend calls for subgroups in an asset group.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/AssetGroups/AssetAssetGroup.tsx	Adds paging UI and paged backend calls for assets in an asset group.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Asset/AssetMeter.tsx	Adds paging UI and paged backend calls for meters tied to an asset.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Asset/AssetLocation.tsx	Adds paging UI and paged backend calls for locations tied to an asset.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Asset/AssetConnection.tsx	Adds paging UI and paged backend calls for asset connections.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Asset/AssetChannel.tsx	Adds paging UI and paged backend calls for connected channels.
Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/AdditionalFields/ByAdditionalField.tsx	Uses paged status/results and adds paging-aware sorting.
Source/Applications/SystemCenter/Model/Security/SecurityGroup.cs	Adds paged users endpoint for security groups.
Source/Applications/SystemCenter/Controllers/OpenXDA/OpenXDALocationController.cs	Adds paged location images endpoint and paging helper.
Source/Applications/SystemCenter/Controllers/OpenXDA/Assets/OpenXDAAssetController.cs	Adds paged endpoints for asset locations/meters/connections/channels.
Source/Applications/SystemCenter/Controllers/OpenXDA/AssetGroups/OpenXDAAssetGroupsController.cs	Adds paged endpoints for asset group members and subgroups.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 31 out of 31 changed files in this pull request and generated 8 comments.

Copilot

Pull request overview

Copilot reviewed 31 out of 31 changed files in this pull request and generated 7 comments.

nbeatty-gpa · 2026-06-25T15:49:06Z

    React.useEffect(() => {
-        if (status == 'uninitiated' || status == 'changed' || parentID != props.Record.ID)
-            dispatch(ValueListSlice.Fetch(props.Record.ID));
-    }, [status, parentID, props.Record.ID]);
+        pagedSearch()
+    }, [pagedSearch, sortField, ascending, page, props.Record.ID]);


comment makes sense but the suggestion is unrelated, which is... interesting

This is actually problemativ for another reason. IF pagedSearch ever change multiple Effects will fire off the same call, which is a potential problem. It also defeats the need for the cleanup function....

clackner-gpa · 2026-06-29T02:04:13Z

    React.useEffect(() => {
-        if (status == 'uninitiated' || status == 'changed' || parentID != props.Record.ID)
-            dispatch(ValueListSlice.Fetch(props.Record.ID));
-    }, [status, parentID, props.Record.ID]);
+        pagedSearch()
+    }, [pagedSearch, sortField, ascending, page, props.Record.ID]);


This is actually problemativ for another reason. IF pagedSearch ever change multiple Effects will fire off the same call, which is a potential problem. It also defeats the need for the cleanup function....

clackner-gpa · 2026-06-29T02:05:25Z

+    const pagedSearch = React.useCallback(() => {
+        const filters = [{ FieldName: "GroupID", SearchText: props.Record.ID.toString(), Operator: "=" as Search.OperatorType, IsPivotColumn: false, Type: "number" as Search.FieldType }];
+        setStatus('loading')
+        const h = controller.PagedSearch(filters, sortField, ascending, page);
+        h.done((d) => {
+            setData(JSON.parse(d.Data as unknown as string))
+            setTotalPages(d.NumberOfPages)
+            setStatus('idle')
+        }).fail((d) => {
+            setStatus('error')
+        })
+        return () => {
+            if (h.abort != undefined) h.abort();
+        }
+    }, [props.Record.ID, sortField, ascending, page, controller.PagedSearch])


This is problematic per comment below. You probably should feed these things into the function as parameter and drop the whole callBack

clackner-gpa · 2026-06-29T02:06:48Z

-    const parentID= useAppSelector(ValueListSlice.ParentID);
-
+    const [data, setData] = React.useState<SystemCenter.Types.ValueListItem[]>([])
+    const parentID = useAppSelector(ValueListSlice.ParentID);


ParentID is used to ensure the slice loads the correct dataset. With the slice gone, you should not be using this anymore.

clackner-gpa · 2026-06-29T02:07:58Z

-import { useAppSelector, useAppDispatch } from '../hooks';
+import { SystemCenter, Application } from '@gpa-gemstone/application-typings';
+import { useAppSelector } from '../hooks';
 import { ValueListSlice } from '../Store/Store';


most likely a change to Controllers allows you to drop the Slice completely,. Mixing slice and controllers is a potential recipe for issues, so I would double check all files and make sure they are really still needed.

clackner-gpa · 2026-06-29T02:09:29Z

-            setUsers(_.orderBy(d, [sortField], asc ? 'asc' : 'desc'));
-            setStatus('idle');
+            getUsers()


this defeats the use of cleanup functions.

clackner-gpa · 2026-06-29T02:10:17Z

+                            { ...newGroup, Name: ((newGroup.Name?.length ?? 0) > 0 ? newGroup.Name : newGroup.DisplayName) }
+                        )
+                        setStatus('changed')
+                        pagedSearch()


defeats the use of cleanup functions and most likely doesn't really grab the latest record since DBAction may not be done yet.

clackner-gpa · 2026-06-29T02:11:07Z

-        </div>;
-
-    useBoundPaging(currentPage, totalPages, setPage)
+    const pagedSearch = React.useCallback(() => {


see other comments. This is not a great pattern to get into.

nbeatty-gpa requested a review from elwills June 10, 2026 19:59

nbeatty-gpa force-pushed the SC-115-Add-pagination-to-all-tables-that-do-not-have-it branch 3 times, most recently from 9b18228 to de09c01 Compare June 15, 2026 14:44

elwills requested a review from Copilot June 18, 2026 19:39

Copilot started reviewing on behalf of elwills June 18, 2026 19:39 View session

Copilot AI reviewed Jun 18, 2026

View reviewed changes

nbeatty-gpa force-pushed the SC-115-Add-pagination-to-all-tables-that-do-not-have-it branch 2 times, most recently from 1b6cf70 to c9e499c Compare June 22, 2026 14:30

elwills requested a review from Copilot June 23, 2026 15:29

Copilot started reviewing on behalf of elwills June 23, 2026 15:30 View session

Copilot AI reviewed Jun 23, 2026

View reviewed changes

nbeatty-gpa force-pushed the SC-115-Add-pagination-to-all-tables-that-do-not-have-it branch from 940fd43 to c8adc11 Compare June 24, 2026 19:07

elwills requested a review from Copilot June 25, 2026 15:13

Copilot started reviewing on behalf of elwills June 25, 2026 15:13 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

nbeatty-gpa force-pushed the SC-115-Add-pagination-to-all-tables-that-do-not-have-it branch from 47f6bcf to f155122 Compare June 26, 2026 20:31

elwills previously approved these changes Jun 26, 2026

View reviewed changes

nbeatty-gpa added 12 commits June 28, 2026 21:49

paginate substation images

721bf2f

reset to first page on sort

6cc7e3e

reset to first page on sort

b41654f

reset to first page on sort

6da27cc

reset to first page on sort

ff48ec4

reset to first page on sort

244725a

fix styling for paging

4ad977e

paginate value list group item

c982b83

page asset ConnectedChannels endpoint

0d45f01

page Asset Channels table

9c998dd

paginate tables tab of external db

d281daa

Fix error filtering users by additional fields

79023f4

nbeatty-gpa added 22 commits June 28, 2026 21:56

cleanup import

49e734c

fix typing

fd8507f

refresh on changed

6bfbd5f

fix broken Additional Field selector in ExternalDBTable

7969c54

fix decimal page

6710ebb

fix grammar mistakes in ExternalDBUpdate

d698f65

do not error out completely on uncompleted search

8e6f1b0

fix utf-A typo

9846e1a

remove companySlice from merged store

bd1805d

abort correct handle

8932c05

return empty PagedResults if no images found for substation

81d4f3b

include 'loading' status during paged search

a416255

filter customer assets on customer ID

7f01b33

add filters to value list

5d3ce60

fix effect cleanup logic

5bcb234

check OrderBy values

4ede62c

correct use of hasPermissions

8065ef6

clean up substation images

60e9475

move valuelistitem away from slices

7502473

remove unused imports

f7b2540

fix use effect returns

e47a81e

cleanup valuelistitem

2f0ba8c

clackner-gpa dismissed elwills’s stale review via 2f0ba8c June 29, 2026 01:56

clackner-gpa force-pushed the SC-115-Add-pagination-to-all-tables-that-do-not-have-it branch from f155122 to 2f0ba8c Compare June 29, 2026 01:56

clackner-gpa requested changes Jun 29, 2026

View reviewed changes

nbeatty-gpa added 5 commits June 29, 2026 13:36

changes to store typing

779b700

fix cleanup function

69e380d

move usergroups away from slices

f1a79e2

update gemstone

6f8ede1

remove DataFileSlice

f76ef59

Uh oh!

Conversation

nbeatty-gpa commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nbeatty-gpa commented Jun 10, 2026 •

edited

Loading