Expose package types via exports types conditions#207
Merged
Conversation
Under `moduleResolution: bundler`/`node16`/`nodenext`, type resolution follows the `exports` map. Since the map only had bare JS paths, TypeScript resolved types to the generated `dist/index.d.ts`, which omitted the type-only members (`ColorScheme`, `ColorVariant`, etc.) that were exposed only by the hand-written ambient `types.d.ts`. Consumers on those resolution modes got "has no exported member" errors. - Re-export the public types from `lib/index.ts` so the built `dist/index.d.ts` is self-describing. - Add a `types` condition to every `exports` subpath pointing at the generated declaration files. The top-level `types`/ambient `types.d.ts` are kept for `node10` back-compat, so the change is purely additive. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
linuspahl
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under
moduleResolution: bundler/node16/nodenext, type resolution follows theexportsmap. Since the map only had bare JS paths, TypeScript resolved types to the generateddist/index.d.ts, which omitted the type-only members (ColorScheme,ColorVariant, etc.) that were exposed only by the hand-written ambienttypes.d.ts. Consumers on those resolution modes got "has no exported member" errors.lib/index.tsso the builtdist/index.d.tsis self-describing.typescondition to everyexportssubpath pointing at the generated declaration files.The top-level
types/ambienttypes.d.tsare kept fornode10back-compat, so the change is purely additive.