Skip to content

Fixes hashicorp/terraform-provider-google#27300#17940

Merged
c2thorn merged 1 commit into
GoogleCloudPlatform:mainfrom
nimam:fix_rule_update
Jun 15, 2026
Merged

Fixes hashicorp/terraform-provider-google#27300#17940
c2thorn merged 1 commit into
GoogleCloudPlatform:mainfrom
nimam:fix_rule_update

Conversation

@nimam

@nimam nimam commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Update Chronicle Rule test was missing a dependency between Rule and DataAccessScope.
This was causing errors during deletion phase of the test.

Fixes hashicorp/terraform-provider-google#27300

@github-actions github-actions Bot requested a review from c2thorn June 11, 2026 22:12
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2ea9dad:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 1 insertion(+)
google-beta provider View Diff 1 file changed, 1 insertion(+)

Test report

Analytics

Total Tests Passed Skipped Affected
43 41 1 1
Affected Service Packages
  • chronicle

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccChronicleRule_chronicleRuleBasicExample_update

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccChronicleRule_chronicleRuleBasicExample_update

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@nimam, @c2thorn, @ankitgoyal0301 VCR tests complete for 2ea9dad!

@nimam

nimam commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

Hi @c2thorn . Can you please review this CL soon. Thanks.

@c2thorn c2thorn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the release note, as this is not a user-facing change. LGTM otherwise, thanks.

@c2thorn c2thorn added this pull request to the merge queue Jun 15, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 0e8a8a3 Jun 15, 2026
31 of 32 checks passed
@nimam nimam deleted the fix_rule_update branch June 16, 2026 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccChronicleRule_chronicleRuleBasicExample_update

3 participants