Skip to content

Add README for GKE TPU Dynamic Slicing with link to the tutorial - #2146

Open
danylott wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
danylott:add-kueue-tpu-tas-readme
Open

Add README for GKE TPU Dynamic Slicing with link to the tutorial#2146
danylott wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
danylott:add-kueue-tpu-tas-readme

Conversation

@danylott

Copy link
Copy Markdown
Contributor

Description

This PR adds the README for standalone YAML manifests for GKE TPU dynamic slicing under ai-ml/gke-tpu-dynamic-slicing/.
Changes included:

  • README.md: Added the standard sample landing page to link directly to the Cloud tutorial

Tasks

  • The contributing guide has been read and followed.
  • The samples added / modified have been fully tested.
  • Workflow files have been added / modified, if applicable.
  • Region tags have been properly added, if new samples.
  • Editable variables have been used, where applicable.
  • All dependencies are set to up-to-date versions, as applicable.
  • Merge this pull-request for me once it is approved.

@dkaluza dkaluza left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but repository owners should take a look

Comment thread ai-ml/gke-tpu-dynamic-slicing/README.md Outdated
@@ -0,0 +1,5 @@
# GKE TPU Dynamic Slicing

These samples show how to configure and use GKE dynamic slicing for Cloud TPUs.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
These samples show how to configure and use GKE dynamic slicing for Cloud TPUs.
These samples show how to configure and use GKE dynamic slicing with Kueue for Cloud TPUs.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done thanks

Comment thread ai-ml/gke-tpu-dynamic-slicing/README.md Outdated
@@ -0,0 +1,5 @@
# GKE TPU Dynamic Slicing

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# GKE TPU Dynamic Slicing
# GKE Kueue TPU Dynamic Slicing

Maybe it is worth it to mention Kueue?
Generally you can use dynamic slices also with "your own scheduler" and this docs are not describing it

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done thanks

@danylott

Copy link
Copy Markdown
Contributor Author

Hi, @NimJay, could you PTAL at this follow up for #2144?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants