Repository navigation
verify-1.6.0-done: PARITY reads golden cell files by the engine's safe name; the pinned judge resolves first, by name - #537
Merged
Conversation
…e name, and resolves the pinned judge first as one named step
The golden-wholeness check looked each PASS row's file up as `id.replace("|", "__") + ".json"`.
The engine names cell files by its `safe_name` (busbar-release differ.rs): `|` -> `__`, then
every byte outside [A-Za-z0-9._+-] -> `_`. The 44 `…@hooks-webrequest` cells live in
`…_hooks-webrequest.json`, so the check reported "the golden is NOT WHOLE: 44 PASS row(s) have no
recorded cell file" about a golden that holds every one (1014 PASS rows, 1014 files). The check
now uses the engine's rule. New selftest arms: a variant cell under its safe name is accepted, and
under its raw id is refused. On the parent, the existing arm "the COMMITTED 1.5.5 golden is whole"
is red.
PARITY's oracle steps (replay-selftest, cells --check, fetch-golden, record, replay) all run the
engine bin/oracle fetches and builds from testing/shadow-oracle/oracle-rust.pin. On a runner that
cannot fetch the private busbar-release (no token, no checkout), each of them failed on its own.
A first step, `parity_resolve_judge` (`bin/oracle tool-dir`), now resolves the judge once and, on
failure, names the pinned ref and the two ways to provide it: a token (never stored), or a git
checkout holding the pinned commit at target/oracle/rust/<ref>/checkout.
MattJackson
enabled auto-merge
October 7, 2026 09:24
promote into
|
| crate | test | step | first panic |
|---|---|---|---|
| `` | nextest xtask::cli::selftest_runs_every_registered_gates_red_proof |
test:workspace | |
transport_dropped_in_serves |
a_dropped_in_transport_registers_through_the_one_fold_and_serves |
test:dropped-in-tcp-transport | crates/busbar/tests/transport_dropped_in_serves.rs:168:13: busbar exited (ExitStatus(unix_wait_status(512))) before serving; log: |
-p busbar --test transport_dropped_in_serves |
test target failed |
test:dropped-in-tcp-transport |
DENY rows (12)
| gate | row | detail |
|---|---|---|
| construction | one-pick-site |
3 production call site(s) of 'pick_among(' (ceiling 2): crates/busbar-kernel-egress/src/walk.rs:298; crates/busbar-llm/src/engine/exhaustion/fallback.rs:120; crates/busbar-llm/src/engine/pipeline.rs:8 |
| kind-isolation | kind-isolation:deps |
3 finding(s), 76 shipped edge instance(s) over 27 class(es), 76 declaration(s); 61 '[[dep]]' row(s), 0 question(s): unlisted-dep-edge legacy -> plane busbar-llm -> busbar-plane-llm is a shipped edge w |
| kind-isolation | kind-isolation:test-deps |
5 finding(s), 36 test edge instance(s) over 19 class(es), 36 declaration(s); 22 '[[dep]]' row(s), 0 question(s): unlisted-dep-edge cleanliness -> legacy busbar-core-admin -> busbar-a2a is a test edge |
| kind-isolation-ship | kind-isolation:deps |
15 finding(s) over 76 shipped edge(s): ship-edge kernel -> hooks busbar-kernel -> busbar-hooks-ranking is 'not-allowed': the architecture grants no kernel -> hooks edge, and the ship criterion is the |
| kind-isolation-ship | kind-isolation:test-deps |
13 finding(s) over 36 test edge(s): ship-edge cleanliness -> legacy busbar-core-admin -> busbar-a2a is 'not-allowed': the architecture grants no cleanliness -> legacy edge, and the ship criterion is t |
| kind-isolation-ship | kind-isolation:faces |
4 finding(s) over 31 crate(s): foreign-entry crates/busbar busbar is kind 'root' and implements 'Store' 2 time(s) in shipped source — the entry face of kind 'store'. A trait implementation is a claim |
| kind-isolation-ship | kind-isolation:testkit |
2 finding(s) over 12 crate(s): battery-ignored crates/busbar-plane-decisions busbar-plane-decisions carries a tests/conformance.rs whose every entry is '#[ignore]'d (or which has none). 'cargo test' |
| kind-isolation-ship | kind-isolation:legacy-drain |
5 finding(s): transitional-live qa/kind-isolation.toml 'busbar-a2a -> busbar-core-admin' (legacy drain: the retiring A2A engine's tests drive the admin surface that drained into the cleanliness tier) |
| kind-isolation-ship | kind-isolation:control-path |
73 finding(s) over 3 control surface(s): upstream crates/busbar-core-admin/src/admin_codec/meta.rs:84 busbar-core-admin names 'egress' — a control surface has no upstream to reach, so the vocabulary o |
| ship-ready | ship-ready:ship-twin |
'kind-isolation-ship' is not green: kind-isolation:deps (a dependency the architecture does not grant is still in the graph); kind-isolation:test-deps (a dependency the architecture does not grant is |
| instance-noun-neutrality | instance-noun-neutrality:voice |
tracked known-debt census — 8: crates/busbar-plane-llm/src/codec/gemini/handler.rs×7 [cross-plugin] | crates/busbar-plane-llm/src/codec/gemini/tests/handler_tests.rs×2 [cross-plugin] | crates/busbar |
| structure-lint | structure-lint:plane-dup:unledgered |
23 finding(s): PLANE-DUPLICATE (module): 'config.rs' — a2a:crates/busbar-a2a/src/a2a/config.rs mcp:crates/busbar-mcp/src/mcp/config.rs voice:crates/busbar-voice/src/config.rs (the ledger row signs for |
Judged against base 70776f1d3: 0 new red, 0 worse, 8 standing (excused).
Reused PASS by input key (1, 1 min not re-run)
| step | key | produced by |
|---|---|---|
| build:deletion-matrix | 1001391dfe6e1f40 |
70776f1d3 |
tests passed: 24680, failed: 1. Run: https://github.com/GetBusbar/busbar/actions/runs/37600443318 . Artifact verdict-2a71ae74865c872d4bc2cc61aea5d1cdec743370 (failures.json, junit.xml, raw.log; 90 days).
MattJackson
added a commit
that referenced
this pull request
Oct 7, 2026
…3-flip-streaming: the census excuses both ruled deletions (busbar-voice, plane-example) and keeps predev's rename rows; census.rs counts the plane_crates drop and the renamed move-outs together, and its tests carry both sets; the oracle pin's history records both lanes' moves to 1869c0032ecf; the hooks-ranking edge is predev's renamed busbar-hook-ranking and openapi-schema names no busbar-voice; the root's linked tests are predev's (the example plane left)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Row 86, from PROOF-DRYRUN's findings on scripts/verify-1.6.0-done.sh (PARITY group).
1. "The golden is NOT WHOLE: 44 PASS rows have no recorded cell file" was the check's error, not the golden's.
assert_golden_wholelooked each file up asid.replace("|","__")+".json". The engine names cell files bysafe_name(busbar-releasediffer.rs:|->__, then every byte outside[A-Za-z0-9._+-]->_). The 44…@hooks-webrequestcells are committed as…_hooks-webrequest.json(c32d7cf, golden-add from the published 1.5.5). Measured on predev: 1014 PASS rows and 1014 cell files under the engine's name. The check now uses the engine's rule. The golden is untouched.2. The judge is resolved once, by name, before any oracle step. replay-selftest,
cells --check, fetch-golden, record and replay all run the engine bin/oracle fetches and builds at the oracle-rust.pin ref. On a runner that cannot fetch the private busbar-release, each failed separately.parity_resolve_judge(bin/oracle tool-dir) is now the group's first step. On failure it names the ref and the two ways to provide it: a token (bin/oracle never stores it), or a git checkout holding the pinned commit attarget/oracle/rust/<ref>/checkout. For the second, bin/oracle must skip the fetch when the pinned commit is already present. #493 rewrites that clone block, so that 4-line change is requested of #493's lane rather than made here, to avoid a conflict.Proof (local, macOS):
bash scripts/verify-1.6.0-done.sh --selftest: GREEN, including two new arms (a variant cell under its safe name is accepted; under its raw id it is refused) and the existing "the COMMITTED 1.5.5 golden is whole";assert_golden_whole testing/shadow-oracle/golden/1.5.5refuses ("44 PASS row(s) have no recorded cell file"); on this branch it passes (1014 = 1014);bash -nclean.Shell only: no crate tests, clippy or fmt apply.