Skip to content

[Fixes #14705][5.1.x] Metadata validation: call validator from admin page - #14709

Merged
giohappy merged 2 commits into
5.1.xfrom
14705_51x_validate_admin
Oct 28, 2026
Merged

giohappy merged 2 commits into
5.1.xfrom
14705_51x_validate_admin

Conversation

@etj

@etj etj commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #14705

TO BE SQUASHED

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@etj etj self-assigned this Oct 8, 2026
Copilot AI balanced review requested due to automatic review settings October 8, 2026 11:07
@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Oct 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Five unresolved moderate findings remain in validator and admin behavior.

1 open finding

🧠 Review effort: Lite


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Comment thread geonode/metadata/admin.py Resolved
@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.06127% with 18 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (5.1.x@5d3243a). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             5.1.x   #14709   +/-   ##
========================================
  Coverage         ?   75.69%           
========================================
  Files            ?      999           
  Lines            ?    63112           
  Branches         ?     8660           
========================================
  Hits             ?    47773           
  Misses           ?    13421           
  Partials         ?     1918           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@etj etj linked an issue Oct 8, 2026 that may be closed by this pull request
@etj
etj requested a review from Gpetrak October 8, 2026 14:44
Comment thread geonode/metadata/admin.py Resolved
Comment thread geonode/metadata/admin.py Resolved
@etj etj added the metadata label Oct 23, 2026
@Gpetrak
Gpetrak self-requested a review October 28, 2026 13:41
@giohappy
giohappy merged commit cc6f811 into 5.1.x Oct 28, 2026
14 checks passed
@giohappy
giohappy deleted the 14705_51x_validate_admin branch October 28, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed metadata

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metadata validation: call validator from admin page

4 participants