Repository navigation
#2608: Integrate Share plugin - #2701
Conversation
| if query_string: | ||
| separator = "&" if "?" in url else "?" | ||
| url = f"{url}{separator}{query_string}" | ||
| return redirect(url) |
There was a problem hiding this comment.
Why we need to implement this the uuid path is already supported e.g. https://stable.demo.geonode.org/catalogue/uuid/cfc35fc2-b8e9-11ec-a50e-0242ac150006
There was a problem hiding this comment.
GeoNode core view uses return redirect(resource) which calls resource.get_absolute_url(), which drops incoming query parameters. This causes shared map URLs to lose view parameters such as bbox, center, and zoom. This override preserves the query string.
Alternatively, we could submit the fix to GeoNode core and remove the override once merged.
There was a problem hiding this comment.
@giohappy suggested it's better to have this in Geonode core, so I will create a PR in core and cleanup this change from the client
|
are you sure the coordinate and zoom params are working in geonode? |
Yes, with override function preserving params, it does share-client.mp4 |
Description
This PR integrates Share plugin
Issue
Screenshot